https://bugzilla.wikimedia.org/show_bug.cgi?id=22018
Summary: Coding conventions
Product: MediaWiki
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: trivial
Priority: Normal
Component: General/Unknown
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: keckeismar...@hotmail.com
Hello,
i am a PHP developer (since about 2004) and working as a softwaredeveloper.
I want to help mediawiki (especially the readability of the source) getting
better.
But first off all here are some suggestions (what i would rewrite first):
* The coding conventions are very "holey" (maybe take a look at
framework.zend.com which are much better)
* If the Classnames, Filenames, ... would have a good convention -> autoloading
would get easy and lines like "require_once(...)" are mostly history
(performance is also better, because the class is only loaded when it's needed
and not on suspicion that it's needed)
* " are only used for SQL statements, because ' is faster
* replace print with echo
* old classes: methods are not declared as public / private and so on
* one class = one file (not more than one class in a file)
* use docblock for classes so all classes could get documentated in phpdoc or
something like that
* reformat every file with the formatting standards
* a good "flow diagramm" where u see: first index.php, which includes this and
this files, ...
* ...
I would have more, but if u like my suggestions, please contact me! I would
help to clean the files from this things...
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
