https://bugzilla.wikimedia.org/show_bug.cgi?id=58137
Web browser: ---
Bug ID: 58137
Summary: Kill SkinTemplateOutputPageBeforeExec hook
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Skin and page rendering
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: jrob...@wikimedia.org
CC: krinklem...@gmail.com, matma....@gmail.com
Classification: Unclassified
Mobile Platform: ---
This hook seems to be very generic and very dangerous - it allows any extension
to redefine template variables in a skin and as a result change the behaviour
of a skin. We are running into various problems in the skin in MobileFrontend
where language_urls in the context of our skin means a list of languages but
that seems to differ from core.
I believe we should understand the existing uses of it and provide more generic
hooks to guide usage.
e.g. in the case of languages a SkinAddLanguageUrl hook would be better as this
would also change the return result of getLanguages.
Can someone make a case for the existing use cases of this hook and why the
hook runs so close to the outputting of the HTML as I'm struggling to see why a
generic hook like this would be better then a more specific one.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
