https://bugzilla.wikimedia.org/show_bug.cgi?id=21844





--- Comment #8 from Tim Starling <tstarl...@wikimedia.org>  2010-01-08 02:59:06 
UTC ---
The problem is the fact that at Parser.php line 2900 (r60825), $isChildObj is
set without $title being set. This is incorrect, you can't have a child object
with no title. This causes line 2995 to create an invalid frame with
$title=null, which then throws fatal errors under various circumstances.

This behaviour of $noparse was apparently added to support DPL2 in r34594,
although DPL2 has since stopped using it. I'm not sure if it set $title.
Theoretically LST could use it (if it set $title correctly) but it doesn't. 

It doesn't really make sense to use $isLocalObj, since that would give you
non-functional edit section links for the current page. If you were getting
text from another page and including it like a template, then $isChildObj could
make sense, since it would give you edit section links to the other page, if
you set $title. 

If the text doesn't come from an editable page at all, then we probably need to
have a flag which can be sent to expand() to suppress the generation of heading
markers. 

So, Jani, can you please explain your application, particularly what sort of
text it is that you're trying to expand? And in that text, what do you expect
triple-braces to do?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to