https://bugzilla.wikimedia.org/show_bug.cgi?id=58262
Web browser: --- Bug ID: 58262 Summary: Flow: JavaScript error trying to highlight URL fragment Product: MediaWiki extensions Version: master Hardware: All URL: http://ee-flow.wmflabs.org/wiki/Talk:First_release#bad OS: All Status: NEW Severity: normal Priority: Unprioritized Component: Flow Assignee: wikibugs-l@lists.wikimedia.org Reporter: sp...@wikimedia.org CC: ebernhard...@wikimedia.org, oke...@wikimedia.org, sp...@wikimedia.org Classification: Unclassified Mobile Platform: --- ui.js tries to highlight whatever's in the URL fragment: highlightPost( $( '.flow-post' + window.location.hash ) ); without any validation that the selector $( '.flow-postXXX' ) exists, so if the fragment isn't loaded yet, or is just random #stuff, the JavaScript code $elem.offset().top fails. Thereafter page JavaScript like collapse/expand icons don't work. With ?debug=1, the console shows (Firefox): [00:07:02.739] TypeError: $elem.offset(...) is undefined @ http://ee-flow.wmflabs.org/w/extensions/Flow/modules/discussion/ui.js:324 or (Chromium): Uncaught TypeError: Cannot read property 'top' of undefined We'll need smarter fragment parsing sooner or later. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l