https://bugzilla.wikimedia.org/show_bug.cgi?id=58259

--- Comment #4 from Krinkle <krinklem...@gmail.com> ---
Note that globalEval doesn't use plain eval(), it uses various tricks to ensure
it is in the neutral and global scope (using the context from the inner
closure, which is bound to the global object).

Whether it optimises or not is a separate question, but if globalEval is
affected by either MediaWiki's or jQuery's closure, that'd be an upstream
jQuery bug. Please make sure that is reported upstream (if not already).

For performance, we can indeed measure both. Make sure though to take into
account that new Function executes in a different way than eval(). The most
significant difference is the returned value (which we don't care about), but
there are other parser context differences that might affect us. Such as
exception handling (we need to know about exceptions so that we can put modules
in the error state).

As long as it is only given single, plain, unwrapped and balanced calls to
mw.loader.implement, it should be fine though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to