https://bugzilla.wikimedia.org/show_bug.cgi?id=58467
Web browser: ---
Bug ID: 58467
Summary: Wrong smart keyword on Wikidata
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Keywords: javascript
Severity: normal
Priority: Unprioritized
Component: DataValues
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: foma...@googlemail.com
CC: jeroen_ded...@yahoo.com,
wikidata-b...@lists.wikimedia.org
Classification: Unclassified
Mobile Platform: ---
Firefox generates smart keywords from a search bar:
https://support.mozilla.org/en-US/kb/how-search-from-address-bar
On Wikidata it generates the wrong bookmark
https://www.wikidata.org/w/index.php?=%s&search=&title=Special%3ASearch
Expected bookmark is
https://www.wikidata.org/w/index.php?search=%s&title=Special%3ASearch
The reason is in the JavaScript code. The original HTML from server is
<form action="/w/index.php" id="searchform">
<div id="simpleSearch">
<input name="search" placeholder="Search" title="Search Wikidata [f]"
accesskey="f" id="searchInput" />
<button type="submit" name="button" title="Search the pages for this
text" id="searchButton">
<img
src="//bits.wikimedia.org/static-1.23wmf6/skins/vector/images/search-ltr.png?303-4"
alt="Search" width="12" height="13" />
</button>
<input type='hidden' name="title" value="Special:Search"/>
</div>
</form>
JavaScript converts this the following HTML code with a duplicate <input>
element:
<form id="searchform" action="/w/index.php">
<div id="simpleSearch">
<input id="searchInput" accesskey="f" title="Search Wikidata
[alt-shift-f]" placeholder="Search" class="ui-autocomplete-input
ui-suggester-input ui-entityselector-input" autocomplete="off" role="textbox"
aria-autocomplete="list" aria-haspopup="true" tabindex="1">
<input type="hidden" name="search" value="">
<button id="searchButton" title="Search the pages for this text"
name="button" type="submit">
<img width="12" height="13" alt="Search"
src="//bits.wikimedia.org/static-1.23wmf6/skins/vector/images/search-ltr.png?303-4">
</button>
<input type="hidden" value="Special:Search" name="title">
</div>
</form>
The JavaScript code on www.mediawiki.org works and converts the HTML to
<form id="searchform" action="/w/index.php">
<div id="improvedsearch-toggle" class="vectorMenu" title="Wikimedia tech"
style="width: 20px; height: 1.3em; margin-left: 14.5em; margin-right:
-0.8em;"></div>
<div id="simpleSearch">
<input id="searchInput" accesskey="f" title="Search MediaWiki
[alt-shift-f]" placeholder="Search" name="search" tabindex="1"
autocomplete="off">
<button id="searchButton" title="Search the pages for this text"
name="button" type="submit">
<img width="12" height="13" alt="Search"
src="//bits.wikimedia.org/static-1.23wmf7/skins/vector/images/search-ltr.png?303-4">
</button>
<input type="hidden" value="Special:Search" name="title">
</div>
</form>
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
