https://bugzilla.wikimedia.org/show_bug.cgi?id=13941
Jack Phoenix <j...@countervandalism.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Low |Lowest
CC| |j...@countervandalism.net
--- Comment #5 from Jack Phoenix <j...@countervandalism.net> ---
This bug fails to address one question: *why* is this a bug? The bug title
basically answers the question, "what happens [when you click on the search bar
and start writing]?" but not why it's considered problematic.
Let's be clear here: I don't know -- nor care -- why the user preference was
introduced in the first place, but mistakes happen even to the best of us, and
that user preference was obviously one.
Connor, you clearly care enough about this bug and appear to know JavaScript
based on comment 4. Therefore I suggest that you write a gadget that overrides
the main search suggestions handler to disable search suggestions on Monobook.
Moving search suggestions to a gadget is simply unacceptable for various
reasons, which include, but are not limited to, the following:
1. said functionality has been present in core for many releases and it's
proven useful
2. it's also been enabled for default for quite a while and removing it all of
a sudden would not only provide an inconsistent user experience, but break
extensions and site scripts relying on the associated jQuery code being present
and available for use in core
Something like this should suffice and it'll make the people concerned with the
"disable search suggestions" being removed happy enough by providing similar
functionality via JS:
$( document ).ready( function() {
if ( mw.config.get( 'skin' ) == 'monobook' ) {
$( '#searchInput' ).unbind();
}
} );
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
