https://bugzilla.wikimedia.org/show_bug.cgi?id=22364
Summary: $wgUseExternalEditor prevents reuploading
Product: MediaWiki
Version: 1.16-svn
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: Normal
Component: Images and files
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: bugzi...@notme.de
CC: gpaum...@wikimedia.org, innocentkil...@gmail.com
If the Setting $wgUseExternalEditor = false is ion effect, no link to reupload
a picture or file is present.
Cause:
In ImagePage.php l.606:
if( $wgUseExternalEditor && $this->img->exists() ) {
$this->uploadLinksBox();
}
Fix:
if( $this->img->exists() ) {
$this->uploadLinksBox();
}
AND surround l.573-584 with an if:
if( $wgUseExternalEditor ) {
$elink = $sk->link(
$this->mTitle,
wfMsgHtml( 'edit-externally' ),
array(),
array(
'action' => 'edit',
'externaledit' => 'true',
'mode' => 'file'
),
array( 'known', 'noclasses' )
);
$wgOut->addHTML( '<li id="mw-imagepage-edit-external">' . $elink . '
<small>' . wfMsgExt( 'edit-externally-help', array( 'parseinline' ) ) .
"</small></li>\n" );
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
