https://bugzilla.wikimedia.org/show_bug.cgi?id=61351
Antoine "hashar" Musso <has...@free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wikibugs-l@lists.wikimedia. |has...@free.fr |org | --- Comment #1 from Antoine "hashar" Musso <has...@free.fr> --- Both jobs above have been triggered by changes made against the deploy repository: https://integration.wikimedia.org/ci/job/parsoidsvc-parsertests-run-harder/601/console https://gerrit.wikimedia.org/r/#/c/112945/ The job is triggered by changes made against either parsoid or parsoid/deploy repository. It fetches both repositories master branch and apply the patch that triggered the job. The src directory of the deploy repository is NOT used. If one look at the full console for the job, a summary of actions is: Refreshing mediawiki/services/parsoid Your branch is behind 'origin/master' by 12 commits, and can be fast-forwarded. + git reset --hard remotes/origin/master HEAD is now at 028e9de Merge "Bug 61243: Catch errors sent by the Parsoid server in roundtrip-test.js" Refreshing mediawiki/services/parsoid/deploy Applying patch refs/zuul/master/Z84552b78386c434d99b94f881fbe96dc + git reset --hard FETCH_HEAD HEAD is now at 77f4aaf... Bump src to 96c127472 for deploy Refreshing mediawiki/services/parsoid/deploy submodules... Submodule 'src' () registered for path 'src' From https://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid 4b751fd..028e9de master -> origin/master Submodule path 'src': checked out '96c1274722bce3b3326954b60cc65ec84c389cea' You end up with the following hierarchy: /parsoid @ whatever master branch was at, i.e. 028e9de /deploy @ 028e9de (which is https://gerrit.wikimedia.org/r/#/c/112945/ patch applied on top of master) /deploy/src Parsoid code @ 96c12747 (since that is what the submodule configuration points to). The tests are run using: NODE_PATH=/deploy/node_modules node parsoid/tests/parserTests... Which mean the Parsoid code being used is the latest from Parsoid when we should test the one mentioned as a submodule :-( That probably cause the issues mentioned. I have to write down somewhere the different use cases and find out what code we actually want to exercice. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l