https://bugzilla.wikimedia.org/show_bug.cgi?id=62971
--- Comment #14 from kipod <fur.hew...@gmail.com> ---
(In reply to Prateek Saxena from comment #13)
> Thanks for the review kipod! Could you please review and/or +1 the patch on
> Gerrit too?
unfortunately, though i have a gerrit account, i did not yet learn to actually
use it. tried a couple of times, but did not persist. i am probably doing
something wrong, and haven't been able to review or +1 using gerrit yet.
as to your comment about style guide: i did not see there anything that says
that
boolvar = <boolean expression> ;
is bad, and we should instead use
if (<boolean expression>) {
boolvar = true;
}
if style guild indeed says that (and i doubt it), then it's a bug in the guide.
as to using "bottom" and "right" instead of "top" and "left" when appropriate:
this is something i learned when i developed [[Module:Chart]] for drawing pie
charts.
it uses a dirty css trick with border bevels, and requires absolutely precise
placement of one corner of the elements, where the corner can be ne, nw, se or
sw.
i could not make this work correctly with enough precision for any corner other
than nw, by calculating "top" and "left", even though i had the exact
dimensions of the elemnt.
when i switched to setting "bottom" or "right" in those cases, it works
precisely as prescribed. i think browsers take some liberties with the
dimensions of the elements, so when you query it in the script to calculate top
and left, you may get somewhat different answers than the actual dimensions
turn out to be. by setting "bottom" and/or "right" when appropriate, you avoid
those problems.
peace.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
