https://bugzilla.wikimedia.org/show_bug.cgi?id=65493
Bug ID: 65493
Summary: Session is started by EditAction
Product: MediaWiki
Version: 1.22.6
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Unprioritized
Component: General/Unknown
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: be...@me.com
Web browser: ---
Mobile Platform: ---
When submitting, SubmitAction#show() is executed, which runs wfSetupSession().
This is a problem for extensions using the UserLoadFromSession hook, as the
SubmitAction is called before the UserLoadFromSession hook.
My extension does it's own session management, using the PHP session manager.
When MediaWiki suddenly runs its own session_start(), it will create a
different session (with a different session name and session id).
How to reproduce:
1. Install an extension that will handle sessions. Mine is
https://www.mediawiki.org/wiki/Extension:SimpleSamlAuth
2. Clear cookies
3. Visit your wiki and log in
4. Observe cookies (only SAML cookies are set)
5. Make a change (it will fail the first time, due to the cookie missing)
6. Observe cookies (both SAML and MediaWiki cookies are set)
Actual results:
MediaWiki will, despite a UserLoadFromSession hook being configured, set it's
own cookie and create it's own session upon submit.
Expected results:
MediaWiki will never set its own cookie because a hook is set.
Note:
- A lot of UserLoadFromSession extensions I have observed call wfSetupSession()
themselves. I think this is not how the hooks are supposed to work, but this
would solve my problem.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
