https://bugzilla.wikimedia.org/show_bug.cgi?id=70337
Bug ID: 70337
Summary: snakview.variations.Value.draw() does not specify
dropValue parameter of jQuery.valueview.stopEditing()
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: WikidataRepo
Assignee: wikidata-b...@lists.wikimedia.org
Reporter: bugzilla.d...@gmail.com
CC: wikidata-b...@lists.wikimedia.org
Web browser: ---
Mobile Platform: ---
In snakview.variations.Value.draw(), jQuery.valueview's startEditing() or
stopEditing() function is called according to whether the ViewState is in edit
mode. stopEditing() is always called without a parameter although the dropValue
parameter should be specified when editing has been canceled (in contrast to
saving). This may not be an urgent problem since the valueview is probably
destroyed after canceling anyway. However, this abuse hints wrong code
architecture and may cause false assumptions and trigger errors in the future.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
