https://bugzilla.wikimedia.org/show_bug.cgi?id=23708

entli...@gmx-topmail.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |entli...@gmx-topmail.de

--- Comment #3 from entli...@gmx-topmail.de 2010-06-17 22:52:59 UTC ---
This is essentially the same as bug 23951. See explanations there.

The culprit is the SyntaxHighlight GeSHi extension adding style="font-family:
monospace;" everywhere. As http://www.brunildo.org/test/monospace_fsize.html
shows, this is the most harmful thing to do because "font-family: monospace;"
is the only thing that triggers the tiny fonts in *all* browsers that have the
problem. In some browsers it can be worked around by adding something else at
any position of the list (even if that "something" is actually a monospaced
font), in others it can be worked around by adding a generic family at the end.

By adding style="font-family: monospace;" as inline style attribute, the
SyntaxHighlight GeSHi extension invalidates the workaround that has been added
to the Vector skin to fix bug 20706. It can be overridded with something like

pre.css.source-css,               /* MediaWiki:*.css, User:*.css */
pre.javascript.source-javascript, /* MediaWiki:*.js, User:*.js */
div.mw-geshi pre,                 /* source enclose="pre" */
div.mw-geshi div,                 /* source enclose="div" */
span.mw-geshi                     /* source enclose="none" */ {
    font-family: monospace, sans-serif !important;
}

The place to fix it is the SyntaxHighlight GeSHi extension itself. It should
stop adding "font-family: monospace;" all over the place and rely on HTML
elements that imply it and leave it up to browsers and skins to deal with them.
It could wrap everything that it doesn't wrap into a pre element into a tt
element. Or, more semantic, wrap everything into a code element and then even
further into a pre, div or nothing (yes, wrapping a code element into a pre
element makes sense).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to