https://bugzilla.wikimedia.org/show_bug.cgi?id=70701
Bug ID: 70701
Summary: Reference bars shouldn't have all styling done with JS
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: WikidataRepo
Assignee: wikidata-b...@lists.wikimedia.org
Reporter: yyairr...@gmail.com
CC: wikidata-b...@lists.wikimedia.org
Web browser: ---
Mobile Platform: ---
A lot of stuff is done to the "# references" bars on items with javascript that
could be done much more efficiently with CSS.
1. JS adds this element to the DOM:
<span class="ui-toggler-icon ui-icon ui-icon-triangle-1-s
ui-toggler-icon3dtrans"></span>
and it does nothing more than add a little arrow image to the bar. CSS ::before
generated content could be used instead. (If it weren't for the little rotate
animation, this would ideally use a background image.)
2. .ui-toggler is constantly listening for mouseovers so that it can add the
"ui-state-hover" class to style the little arrow. Solution: Use the :hover
pseudoclass.
3. JS adds all sorts of classes all over the place to style it differently than
how the JS-disabled users get. Solution: Use .client-js CSS to have it styled
right in the first place.
There is no reason for JS to be fiddling with this bar at all unless the user
actually clicks on it.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
