https://bugzilla.wikimedia.org/show_bug.cgi?id=62266
--- Comment #28 from Tisza Gergő <gti...@wikimedia.org> --- There has been considerable debate over this, so I'll try to summarize the options, and then we can pick which are good candidates for in-depth testing. I'll try to list the benefits and disadvantages of each approach, please fix where you feel it's biased. A: keep current behavior * pro: follows standard web logic of one URL - one history entry * con: gets in the way when browsing several articles in the same tab B: don't change URL at all, don't add history entries * pro: decreases complexity of code * con: sharing image-over-article becomes less intuitive, breaks sharing via devices/tools which use URL directly C: change URL but do not add history entries * pro: easy to implement (now that IE7 is grade C) * con: mispredicting browser behavior is costly (clicking on back to go back to previous image will instead cause you to leave the page, and probably lose scroll position), no one seems to be doing this D: add a history entry when you enter the lightbox, but don't add new ones for next/prev navigation * pro: easy to implement (now that IE7 is grade C) * con: can still get in the way when going back to previous article (although much less so than the current behavior), no one seems to be doing this E: Facebook-style: nuke all MediaViewer-related history entries once the user exits MediaViewer * pro: Facebook does it, fits an "app" mental model well * con: unusual, cross-browser implementation might be problematic F: Google Photos style: like D but nuke the history when exiting the lightbox * pro: Google does it * con: unusual, cross-browser implementation might be problematic G: do E or F but use History API, drop older browser support * pro: consistent browser behavior, easy to implement, better URL i18n * con: need to drop IE 8-9, makes HTML caching problematic An example to make the differences clear: users visits article -> clicks on image 1 -> clicks on next, sees image 2 -> clicks on close -> clicks on image 4 -> clicks on next, sees image 5 -> clicks on close The history stack will look like this: A: a -> a,1 -> a,1,2 -> a,1,2,a -> a,1,2,a,4 -> a,1,2,a,4,5 -> a,1,2,a,4,5,a B: a -> a -> a -> a -> a -> a -> a C: a -> 1 -> 2 -> a -> 4 -> 5 -> a D: a -> a,1 -> a,2 -> a,2,a -> a,2,a,4 -> a,2,a,5 -> a,2,a,5,a E: a -> a,1 -> a,1,2 -> a -> a,4 -> a,4,5 -> a F: a -> a,1 -> a,2 -> a -> a,4 -> a,5 -> a -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
