https://bugzilla.wikimedia.org/show_bug.cgi?id=24159
Summary: Remove uses of the error suppression operator
Product: MediaWiki
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Keywords: easy
Severity: minor
Priority: Normal
Component: General/Unknown
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: innocentkil...@gmail.com
Blocks: 700
"Error suppression operators have lots of implementation issues in PHP, they
are evil and should almost never be used."
and
"Don't use the error suppression (@) operator for any reason ever. It's broken
when E_STRICT is enabled and it causes an unlogged, unexplained error if there
is a fatal, which is hard to support. Use wfSuppressWarnings() and
wfRestoreWarnings() instead."
Somebody should go through MediaWiki and remove the 87 uses of it and replace
it with appropriate error checking. Things like array indexes can be checked
with isset(), some things should actually get wfSuppressWarnings() and
wfRestoreWarnings() (permission errors on file operations are a good example).
Tagging this easy for somebody with some spare time.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
