https://bugzilla.wikimedia.org/show_bug.cgi?id=24186
lampak <llam...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7537|0 |1 is obsolete| | Attachment #7538|0 |1 is obsolete| | Attachment #7540|0 |1 is obsolete| | Attachment #7539|0 |1 is obsolete| | --- Comment #4 from lampak <llam...@gmail.com> 2010-07-01 09:33:15 UTC --- Created an attachment (id=7538) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7538) patch no. 2 Small quick fix of one line. I'm not sure it's much better but I'm hurrying a bit (because of real-life reasons). --- Comment #5 from lampak <llam...@gmail.com> 2010-07-01 10:55:43 UTC --- The patch doesn't work! Sorry for the mess. --- Comment #6 from lampak <llam...@gmail.com> 2010-07-01 11:07:07 UTC --- Created an attachment (id=7539) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7539) patch no. 3 --- Comment #7 from lampak <llam...@gmail.com> 2010-07-01 11:15:12 UTC --- Created an attachment (id=7540) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7540) patch no. 3 with extra modifications from previous patches Ok, this one should work. In this version it turns out I don't use that canSeeDetails so there's no need to move these functions. But I don't think it was a bad idea anyway so you here have two versions of a patch for you to decide. Sorry for the mess and confusion and everything. This is what happens when you try to do something quickly :/ --- Comment #8 from lampak <llam...@gmail.com> 2010-07-01 11:22:26 UTC --- Created an attachment (id=7541) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7541) patch no. 3a with extra modifications from previous patches --- Comment #9 from lampak <llam...@gmail.com> 2010-07-01 11:24:05 UTC --- Created an attachment (id=7542) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=7542) patch no. 3a Just a small fix of spaces/tabs issue. That's really the end, I promise. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l