https://bugzilla.wikimedia.org/show_bug.cgi?id=73163

--- Comment #3 from Brad Jorsch <bjor...@wikimedia.org> ---
(In reply to Sam Reed (reedy) from comment #1)
> At a quick glance, just an empty array should work...

You missed that an empty array is specifically rejected:

>               if ( !is_array( $this->autocomplete ) || !$this->autocomplete ) 
> {
>                       throw new MWException( 'HTMLAutoCompleteSelectField 
> called without any
> autocompletions' );
>               }

"!$this->autocomplete" is true if it's an empty array.

Since there's no point in offering an 'other' text field when nothing is valid
as input (besides maybe duplicating the value of one of the options in the
dropdown), let's just skip it altogether in that situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to