https://bugzilla.wikimedia.org/show_bug.cgi?id=73570
Bug ID: 73570 Summary: VisualEditor: Improve FileDropHandler API Product: VisualEditor Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: Technical Debt Assignee: jforrester+veteambztick...@wikimedia.org Reporter: roan.katt...@gmail.com CC: elitr...@gmail.com, etonkovid...@wikimedia.org, jforres...@wikimedia.org, ryasm...@wikimedia.org Web browser: --- Mobile Platform: --- From comments at https://gerrit.wikimedia.org/r/#/c/173296/1/src/ui/filedrophandlers/ve.ui.DSVFileDropHandler.js : * Right now every child class calls createProgress( insertableDataDeferred.promise() ); in its process() method. This seems like something that should be in the base class instead. Would you ever want to not do that, or pass a different promise? * Child classes should not have to override abort() just to add this.reader.abort();, because this.reader is added by the base class. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l