https://bugzilla.wikimedia.org/show_bug.cgi?id=21919

--- Comment #36 from Jason Giglio <g...@gigstaggart.com> 2010-11-29 05:12:58 
UTC ---
I know I merged two of the files.  The renaming, I don't remember if I did it
or if it's happened in SVN since my development started.  

As far as my changes, mostly from memory:

Started to clean up the parameter handling to use wgrequest instead of the home
rolled thing.  This means the documentation is going to be wrong about the
naked options (i.e. you need to use var=option instead of just /option)

Major cleanup of the incorrect indent levels.  All spaces should be tab chars
now per the MW standards.

Merged the XML generation into the main file.  Still need to move that to
XMLWriter or something similar, but the structure of what it's doing is similar
now.  Moved some of it out of a class where it didn't really belong.

Cut out some sections of cruft, and simplified many of the deeply nested "if"
statements to use early return logic.

Broke the "notcategories" handling, I don't remember why but there was a good
reason.  I think it was part of the params conversion.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to