https://bugzilla.wikimedia.org/show_bug.cgi?id=26172
--- Comment #7 from Chad H. <innocentkil...@gmail.com> 2010-11-30 17:56:15 UTC --- (In reply to comment #4) > Which php version is used? 5.3.2. (In reply to comment #2) > Not that I'm adversed to this, but I thought that we didn't want to do a > pre-commit hook as it blocks? > I don't like the idea of doing extensive pre-commit hooks due to that issue. But php -l is typically very fast. > And would be especially annoying for large (i18n) > etc commits...? > It may be, we're not sure yet. Gonna test it later with Raymond. > Also, what if the file already had it in...? (Granted, if it was tested, they > would've found it..) > Then you fix it too, while you're at it ;-) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
