https://bugzilla.wikimedia.org/show_bug.cgi?id=23720

Roan Kattouw <roan.katt...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roan.katt...@gmail.com

--- Comment #4 from Roan Kattouw <roan.katt...@gmail.com> 2010-12-31 21:07:31 
UTC ---
(In reply to comment #3)
> As Roan suggests, this should be fixed by storing paths more redundantly, so
> the LIKE can be made into an equality check.  Otherwise there's no way to get
> it to play nice with the grouping/ordering.

Elaborating on my suggestion on IRC:

Currently we only store the path of each changed file in the paths table. If
instead we also stored the paths of all of their ancestors, we could simply do
WHERE cp_path='/trunk/phase3' instead of WHERE cp_path LIKE '/trunk/phase3%' ,
which will search directories recursively.

For example, for a commit that touches ApiQueryBase.php and MessagesEn.php,
we'd store the following paths:

/trunk/phase3/includes/api/ApiQueryBase.php
/trunk/phase3/includes/api
/trunk/phase3/includes
/trunk/phase3/languages/messages/MessagesEn.php
/trunk/phase3/languages/messages
/trunk/phase3/languages
/trunk/phase3
/trunk

This would improve query performance at the expense of table size.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to