https://bugzilla.wikimedia.org/show_bug.cgi?id=26613
Happy-melon <happy-me...@live.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Severity|major |enhancement
--- Comment #3 from Happy-melon <happy-me...@live.com> 2011-01-06 21:53:34 UTC
---
$form = new HTMLForm( array(
'Text' => array(
'type' => 'text',
'default' => 'foo',
),
'TextOverridden' => array(
'type' => 'text',
'name' => 'DifferentTextOverridden',
'default' => 'foo',
),
'ArrayName' => array(
'type' => 'hidden',
'default' => 'foo',
),
'ArrayNameOverridden' => array(
'type' => 'hidden',
'name' => 'DifferentArrayNameOverridden',
'default' => 'bar',
),
) );
$form->addHiddenField( 'FunctionName','baz' );
$form->setTitle($this->getTitle());
$form->displayForm('');
=== 1.16.1 ===
<input name="wpText">
<input name="wpTextOverridden">
<input type="hidden" name="FunctionName">
<input type="hidden" name="ArrayName">
<input type="hidden" name="ArrayNameOverridden">
=== trunk ===
<input name="wpText">
<input name="DifferentTextOverridden">
<input type="hidden" name="FunctionName">
<input type="hidden" name="wpArrayName">
<input type="hidden" name="DifferentArrayNameOverridden">
The main change in 1.17 was to introduce the 'name' override: if you specified
'name' => 'Foo' in the descriptor array, that would be used unconditionally,
and without any modification. That applies to all types of fields. Given
that, there's no reason to special-case hidden fields *except* for B/C. And as
I said on IRC, I'd rather have it consistent and transiently incompatible, than
inconsistent forever.
Specific issue raised was fixed in r79758.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
