https://bugzilla.wikimedia.org/show_bug.cgi?id=17160
Ilmari Karonen <nos...@vyznev.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nos...@vyznev.net --- Comment #15 from Ilmari Karonen <nos...@vyznev.net> 2011-02-12 17:13:54 UTC --- (In reply to comment #14) > Somewhat tested patch is at http://translatewiki.net/sandwiki/gender.txt . Minor suggestion: the structure you suggest for the $namespaceGenderAliases array looks kind of ugly to me. Something like $namespaceGenderAliases = array( NS_USER => array( 'male' => 'Male_user', 'female' => 'Female_user' ), ); would make more sense to me. Also, you might want to skip the GenderCache::needed() "shortcut" and just call $wgContLang->needsGenderDistinction() from LinkBatch directly. That way you should be able to avoid loading GenderCache.php at all for wikis that don't need it. The rest of it looks pretty good to me, though. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l