https://bugzilla.wikimedia.org/show_bug.cgi?id=18283

--- Comment #3 from Reedy <s...@reedyboy.net> 2011-03-19 21:27:00 UTC ---
We have a bit more of a clue of why a diff failed now..

I guess we can cache some as permanent failures (ie it will never load
correctly)

    public static function getDiffErrorMessage( $error ) {
        switch( $error ) {
            case self::DIFFRESULT_BadRevision:
                return 'Bad revision specified.';
            case self::DIFFRESULT_TooManyPaths:
                return 'Too many paths returned to diff';
            case self::DIFFRESULT_NoDataReturned:
                return 'No data returned for diff';
            case self::DIFFRESULT_NotInCache:
                return 'Not in cache';
            default:
                return 'Unknown';
        }
    }

But probably some more work needs doing...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to