https://bugzilla.wikimedia.org/show_bug.cgi?id=19725
--- Comment #19 from Bawolff <bawolff...@gmail.com> 2011-05-07 05:20:45 UTC --- Created attachment 8516 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8516 Patch to make suppressed revisions not be counts when doing prefix search of special:undelete or on the '$1 deleted revisions' message when viewing a deleted page Here's a patch that does the following. *Makes the "x deleted edits" message at the top of a deleted page not count suppressed revisions. *Makes suppressed revisions not show up when doing a prefix search of special:undelete. (It will count non-suppressed revisions only in the prefix search) I used if the revision's text (content) is hidden from admins as the test for if to count in both the above cases. If you directly go to the undelete of that page, the suppressed revisions are still shown as they are now. (To do that would already require knowing what the page's title is, so it doesn't exactly reveal the secret title). If you have the suppressrevision right, then everything behaves like it does currently Potential concerns with this patch (aka reasons I attached it to a bug instead of committing) *Does it make sense to show different number of deleted revisions depending on if you have suppressrevision right, and have no indication that different numbers are shown to users without that right? *Does it make sense to not count the revision only if the revision text is hidden from admins (at the end of the day the core of a deleted edit, is the text of that edit. OTOH, it might make sense to not count it only if the entire thing is suppressed, or perhaps if any part of it is suppressed. For comparison, special:deletedcontribs looks at the user field [but that makes sense since its per user]). *Minor db concern. The query no longer uses a covering index. Does that matter? I don't think it does, but I'm not overly knowledgeable about these types of performance concerns. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
