https://bugzilla.wikimedia.org/show_bug.cgi?id=28797

--- Comment #8 from Roan Kattouw <roan.katt...@gmail.com> 2011-05-09 11:43:31 
UTC ---
(In reply to comment #7)
> Fixed in r87627.  It was actually a bug in the API which was exposed by 
> r83796,
> rather than being introduced by it.
The function you "fixed" doesn't expect nested arrays, and the documentation
mentions this (even if in passing; it says it expects and *element* of a nested
errors array), so whatever was feeding it nested arrays was at fault. The
array_shift()ing was done by the callers.

Either way, it's probably cleaner to make the de-nesting the responsibility of
parseMsg() like you did.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to