https://bugzilla.wikimedia.org/show_bug.cgi?id=30421
MZMcBride <b...@mzmcbride.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #3 from MZMcBride <b...@mzmcbride.com> 2011-08-17 17:43:34 UTC ---
Re-opening this. My comment from CodeReview:
This isn't a scalable solution and this just adds further English
Wikipedia-specific code to what's supposed to be a generic extension. I
recommend reverting this.
I'm also not sure that hiding the banners on the mobile site, in general, is a
good idea. They could equally be hidden from logged-out users on the main
(non-mobile) site, but specifically are not. There seems to be some rendering
issues with them, but that's a problem with the extension, I imagine.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
