https://bugzilla.wikimedia.org/show_bug.cgi?id=17791
--- Comment #8 from Brion Vibber <br...@wikimedia.org> 2011-08-29 18:44:06 UTC
---
Looks like fairly reasonablish code overall, but all this really needs a
testing plan to confirm that it fixes the described bugs and doesn't cause
regressions.
Are bits like this code necessary?
if( !imageinfo.thumburl ) {
44
// Unable to fetch a thumbnail, use the image without
scaling and lie about its size
45
// This works only for non-paged files though
46
if ( mw.config.get( 'proofreadPageFilePage' ) == null )
{
47
height = ( quantizedWidth / fullWidth ) *
fullHeight;
48
callback( imageinfo.url, quantizedWidth, height );
49
}
50
}
this seems to be redundant; per comments above, we should get back a thumburl
entry whenever we've asked for a size, and we should always be asking for a
size ("original size" may be unreasonably *huge* for some scans).
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
