https://bugzilla.wikimedia.org/show_bug.cgi?id=30339

--- Comment #11 from Ashar Voultoiz <has...@free.fr> 2011-10-20 13:58:13 UTC ---
I added some minor patches (see branch commits).

Is there any reason you are loading the QUnit module directly from the resource
loader constructor? It would be better placed in
includes/specials/SpecialJavaScriptTest.php constructor. Since those resources
are only needed for the dedicated special pages, that sounds like a waste of
cpu/memory for all the other requests.

Apart for this point above, seems it could be merged to core.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to