https://bugzilla.wikimedia.org/show_bug.cgi?id=31965

--- Comment #2 from MZMcBride <b...@mzmcbride.com> 2011-10-26 23:49:55 UTC ---
(In reply to comment #1)
> So far for the build in PHP mail validation function... wtf...

I imagine it's accounting for something like... user@localhost.

> The email address field in the signup form should default to your set email
> address if you have any. Just had a look, and this appears to work as it
> should.

Yes, it does. But...
> You are right that changing the address should cause it to be in
> non-validated state, this is something I overlooked.

Much more importantly, if it's going to change user.user_email to a new value,
it should first confirm this with the user. "Your e-mail address is currently
set to f...@bar.com. You've indicated that your e-mail address is b...@bang.com.
Would you like to update your Wikimedia account?" Or something.

> However, the change of the user email field is deliberate, and was discussed
> before creating the extension.

Changing the e-mail address is fine. _Silently_ changing it is not.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to