| Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE triaged this task as "Normal" priority. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality. |
For T185709: Cache CheckResult serializations per-entity in ObjectCache, we cannot just store Message objects – the parameters which we pass to our messages contain entity labels, which are already language-specific. We need something more at the ConstraintParameterRenderer level: a message object with parameter types like “string”, “entity ID”, “list of item IDs”. Only when the message is finally rendered do we pass those parameters into, say, an $entityIdLabelFormatter.
This also means one less object to inject into all checkers: the checkers will instantiate such a message, which is a pure value object, and the task of rendering it is then delayed until the CheckConstraints API or SpecialConstraintReport, which means that the checkers no longer need a ConstraintParameterRenderer.
Cc: Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
