[Wikidata-bugs] [Maniphest] [Updated] T186035: Autocomment-like snippets in labels, descriptions or aliases are rendered like additional autocomments

[thiemowmde]

thiemowmde added subscribers: Lydia_Pintscher, thiemowmde, WMDE-leszek. thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Technical-Debt. thiemowmde added a comment.

I can not think of a good way that utilizes escaping to avoid this.

What we could do is to apply some validation to user-provided summaries, and deny to accept user-provided text that looks like one of our autosummaries.

An other possibility is to add this to our FormatAutocomments hook handler at the top of RepoHooks::onFormat:

if ( $pre ) {
	return;
}

With this, only the first autocomment in a summary line gets parsed and localized. Since all summaries our code produces conform to this (see SummaryFormatter::assembleSummaryString), I believe introducing this limitation would actually be consistent.

Note that T184702 might start using the fact such a limitation was never implemented as a feature.

TASK DETAIL

https://phabricator.wikimedia.org/T186035

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: WMDE-leszek, thiemowmde, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs