[Wikidata-bugs] [Maniphest] [Created] T187855: Undefined index in WikibaseClient $this->getRepositoryDefinitions()->getDatabaseNames()['']

[Tgr]

Tgr created this task. Tgr added projects: MediaWiki-extensions-WikibaseClient, MediaWiki-Vagrant. Herald added a subscriber: Aklapper. Herald added a project: Wikidata.

TASK DESCRIPTION

After pulling up a new vagrant box with the wikidata role and visiting the main page of the default wiki (dev.wiki.local.wmftest.net) I get Notice: Undefined index: in /vagrant/mediawiki/extensions/Wikibase/client/includes/WikibaseClient.php on line 543. That line is in WikibaseClient::getStore and contains $this->getRepositoryDefinitions()->getDatabaseNames()['']. The getDatabaseNames call returns an empty array as the database for the empty string repository is null, and there is an is_null filter preventing that from getting in the result. The null value does not seem unexpected, client/config/WikibaseClient.default.php has

// Use false (meaning the local wiki's database) if this wiki is the repo,
// otherwise default to null (meaning we can't access the repo's DB directly).
'repoDatabase' => $settings->getSetting( 'thisWikiIsTheRepo' ) ? false : null,

Presumably introduced by rEWBAf9e431c26c06: Integrate all Client's repository settings into a single setting.

TASK DETAIL

https://phabricator.wikimedia.org/T187855

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Aklapper, Tgr, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, Mbch331, jeremyb

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs