| Legoktm added a comment. |
The suggestion is to not replace … extends \PHPUnit_Framework_TestCase with … extends \PHPUnit\Framework\TestCase, but with … extends TestCase and an import in the use section above. This fits better to the code style the Wikidata team is used to, where full qualified class names are avoided.
Please don't do this until someone fixes the structure test to support this: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/tests/phpunit/structure/StructureTest.php#28
TASK DETAIL
EMAIL PREFERENCES
To: Legoktm
Cc: Legoktm, gerritbot, Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g
Cc: Legoktm, gerritbot, Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, RazeSoldier, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Lewizho99, Maathavan, TerraCodes, MuhammadShuaib, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
