| Lucas_Werkmeister_WMDE added a comment. |
Because I can’t think of anything SQL-related in that change… it shouldn’t result in any new SQL queries
Okay, that was wrong. There are new SQL queries: for each wbcheckconstraints request, one or two queries to get the latest revision ID for a set of entity IDs (one for a cache hit to see if the cached result is still valid, one for a cache miss to add the entity IDs to the cache, and it’s possible for both to occur in one request if the cached result is invalid), via WikiPageEntityMetaDataLookup. And I think that set isn’t explicitly limited to any particular size anywhere, which is probably bad.
Do you have the query text of the killed queries? Were they queries like this code could produce – joining page, revision, and text?
TASK DETAIL
EMAIL PREFERENCES
To: Lucas_Werkmeister_WMDE
Cc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot, Liuxinyu970226, Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, mmodell
Cc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot, Liuxinyu970226, Jonas, Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, mmodell
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
