[Wikidata-bugs] [Maniphest] [Commented On] T188381: Avoid joining three tables just to get the latest revision ID

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.

I just saw this in WikiPageEntityRevisionLookup:

public function getLatestRevisionId( EntityId $entityId, $mode = self::LATEST_FROM_REPLICA ) {
    $rows = $this->entityMetaDataAccessor->loadRevisionInformation( [ $entityId ], $mode );
    $row = $rows[$entityId->getSerialization()];

    if ( $row && $row->page_latest && !$row->page_is_redirect ) {
        return (int)$row->page_latest;
    }

    return false;
}

Note that it’s only using page_latest if the page is not a redirect. We’re not currently doing that in loadLatestRevisionIds… is that a problem?

TASK DETAIL

https://phabricator.wikimedia.org/T188381

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: gerritbot, daniel, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs