[Wikidata-bugs] [Maniphest] [Commented On] T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job

[zeljkofilipin]

zeljkofilipin added a comment.

In T197875#4307078, @WMDE-leszek wrote:

The reason why I think Wikibase code is needed is that WikibaseLexeme/tests/browser/features/support/env.rb contains following stuff:

require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features/support/modules'

/me facepalms 🤦‍♂️

Of course. I should have noticed that.

Anyway, it's a code smell if a repository just assumes another repository would be available at a precise location. If some code is shared between Wikibase and WikibaseLexeme it belongs to a library, probably mediawiki_selenium Ruby gem. If you think it's Wikibase specific maybe a new gem, mediawiki_selenium-wikibase?

TASK DETAIL

https://phabricator.wikimedia.org/T197875

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin
Cc: WMDE-leszek, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs