bearND added a comment.

@Jdlrobson Thanks for the updated patch!

@Jdlrobson @phuedx I see some discrepancies between https://www.mediawiki.org/wiki/Page_Previews/API_Specification and this task description.

  • "type": "wikidata" vs "wikidata_preview"
  • Extra attributes: number of sitelinks and claims in @Jdlrobson's patch vs. "wikidata_label" on the spec page.

Let's agree on what we want here and update the two sides (task vs spec page) to keep in sync. I'm not sure why we would need the number of sitelinks and claims but I can live with them if they are indeed needed by clients. If there is no immediate use for them I would prefer to keep them out for now. We can add properties later, just not remove them without breaking BWC.


TASK DETAIL
https://phabricator.wikimedia.org/T111231

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bearND
Cc: bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to