| Addshore added a comment. |
DataValueDeserializer::__construct docs should be updated to say what types of exceptions the builders can throw.
A better fix (than the current gerrit patch) might actually be to catch the EntityIdParsingException in the closure in WikibaseRepo and return another InvalidArgumentException from there, this would be consistent with the other builders.
This would then be re caught in DataValueDeserializer::getDeserialization and rethrown as a DeserializationException which would be handled by SetClaim..
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair
Cc: Pablo-WMDE, Addshore, Ladsgroup, gerritbot, Krinkle, TerraCodes, Liuxinyu970226, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
