[Wikidata-bugs] [Maniphest] [Commented On] T199855: WikidataPageBanner breaks Vector page subtitle

Sun, 29 Jul 2018 19:42:13 -0700

Jdlrobson added a comment.

I see 2 options here

  1. Only do the subtitle fix when a banner exists (e.g. add `&& banner``` to https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/7d39c374cc589d9ecd714976d5508ca5f6b133c9/includes/WikidataPageBanner.hooks.php#62)
  2. We disable the extension on test2 wiki

Will happily merge a patch for 1. Right now I am the only active maintainer of the extension and not wanting to self merge I can't submit a patch for 1.


TASK DETAIL
https://phabricator.wikimedia.org/T199855

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Jdlrobson, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Jrbranaa, QZanden, LawExplorer, Winter, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to