[Wikidata-bugs] [Maniphest] [Changed Project Column] T196882: Create a code abstraction for "display entity link" use-case

[Aleksey_WMDE]

Aleksey_WMDE moved this task from Peer Review to Doing on the Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing) board. Aleksey_WMDE added a comment.

Found the problem with current solution.

lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:142

if ( $row && $row->page_latest && !$row->page_is_redirect ) {
	return (int)$row->page_latest;
}

return false;

That means that we don't get correct revision ID if the target entity is redirect.
That leads to invalid cache record (or Exception being thrown if the patch 452931 is merged) and essentially means that the code is not production ready.

It still can be deployed as soon as this code is disabled using configuration value.

TASK DETAIL

https://phabricator.wikimedia.org/T196882

WORKBOARD

https://phabricator.wikimedia.org/project/board/3407/

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aleksey_WMDE
Cc: Aklapper, gerritbot, Aleksey_WMDE, WMDE-leszek, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs