Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION

Problem:
Since T46727: [Story] Statement should show a thumbnail for image/video/audio properties was implemented, constraint violations of media values look weird: the media preview takes up the full width of the value, and the indicators, including the constraints icon, are placed below it, with some awkward padding.

Screenshot:
F25635309: Screenshot_2018-09-03 Wikidata Sandbox.png

Implementation notes:
One way to fix this for media values is to make the .wikibase-snakview-value have display: inline-block instead of inline. But that results in awkward vertical alignment for the indicators –
F25635364: Screenshot_2018-09-03 Wikidata Sandbox(1).png
– and is also terrible for plain text values, which then have exactly the same problem:
F25635370: Screenshot_2018-09-03 Wikidata Sandbox(2).png
I’m not sure what else can be done here. Perhaps displaying the icon below the value is actually okay if we can get rid of the bit of padding, so that it’s flush with the left edge of the media preview?


TASK DETAIL
https://phabricator.wikimedia.org/T203405

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to