| Pablo-WMDE updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
In tests interacting with the database (writing to it), `MediaWikiTestCase` can help us to clean up, but it needs `tablesUsed` to be specified*[0] to work.
Tools can help us to [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/461120 | find the places in question ]], but [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/461428/ | adding the tablesUsed ]] and thus allowing the reset could reveal sloppy setUp of other tests, that rely on previously existing entities.
*[0] most tests will only require "page" to be specified as this is [[ https://github.com/wikimedia/mediawiki/blob/3842fd20799f80116b3a32b601ec67e97b71bae8/tests/phpunit/MediaWikiTestCase.php#L1706 | expanded ]] to cover more tables that go along with it
Tools can help us to [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/461120 | find the places in question ]], but [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/461428/ | adding the tablesUsed ]] and thus allowing the reset could reveal sloppy setUp of other tests, that rely on previously existing entities.
*[0] most tests will only require "page" to be specified as this is [[ https://github.com/wikimedia/mediawiki/blob/3842fd20799f80116b3a32b601ec67e97b71bae8/tests/phpunit/MediaWikiTestCase.php#L1706 | expanded ]] to cover more tables that go along with it
TASK DETAIL
EMAIL PREFERENCES
To: Pablo-WMDE
Cc: Aklapper, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
Cc: Aklapper, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
