| hoo added a comment. |
In T204066#4707450, @Ladsgroup wrote:I looked at this today and I think we should revisit the estimation for this task. The reason it doesn't work is that ImageLinksDataUpdater gets an entity and only adds image usages for the entity and not its subentities. The only possible way that I can think of is to add a "getSubEntities()" to EntityDocument interface and implement it with empty value everywhere, then use it in EntityStatementDataUpdaterAdapter + praying that in future we don't end up having subentities that would have subentities of their own.
I would suggest to create a new interface for this method, should it be added… I don't think we should clutter up EntityDocument with that.
An alternative would be to create a new interface containing a method that is defined to return all statements (from the entity itself+sub entities). A possible name would be getDependentStatements/DependentStatementListProvider or getSubordinatedStatements/SubordinatedStatementListProvider. This way, we would have a mechanism that is subentity agnostic and we don't need WikibaseRepo to do the right thing™ with the subentities.
Cc: hoo, Ladsgroup, Nikki, Lydia_Pintscher, Lea_Lacroix_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, Jonas, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Darkdadaah, Matanya, Mbch331, Tgr
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
