| Joe added a comment. |
In T212189#4833482, @daniel wrote:I agree with Joe that it would be better to have the service be internal, and be called from MW. It doesn't have to be that way, but it's preferable because:
- we would not expose a new endpoint
- we should in general avoid (more) services calling MediaWiki, because:
- PHP has high startup time, and also for reasons of general hygiene of the architecture
- we don't want MW and external services calling each other, back and forth
- "pure functional" services that do not interact with storage are easier to reason about, and easier to run and maintain.
However, these are general considerations. I see nothing that would totally block the architecture as proposed, if there are good reasons for doing it this way.
Well, I consider calling the MW api from a service called by MediaWiki an antipattern that we should absolutely avoid.
So either of these options is viable IMHO:
- MediaWiki can send to the service all the data it needs to generate the termbox, without further calls to the api
- The rendering is done in the browser, with the server-side service acting as a public-facing fallback for browsers not supporting workers
I don't want to introduce another circular dependency between MediaWiki and another service.
Is the technical difficulty in doing so that the request has been set up for $wiki and we need information from wikidata?
TASK DETAIL
EMAIL PREFERENCES
To: Joe
Cc: daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, faidon, Nikerabbit, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
Cc: daniel, mobrovac, Joe, Matthias_Geisler_WMDE, Jakob_WMDE, Pablo-WMDE, Aklapper, Lydia_Pintscher, Lea_WMDE, Addshore, WMDE-leszek, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, D3r1ck01, SBisson, Wong128hk, Eevans, Hardikj, Wikidata-bugs, aude, faidon, Nikerabbit, Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
