alaa_wmde added a comment.
@Addshore I've been investigating this one for a while. It seems that data types are not really stored in localStorage. I checked locally, on beta and on production but couldn't find any localStorage entries apart from very basic ones. Since I have the data type enabled on my local instance, and haven't experienced the same issue before (even with caching settings all kept turned on), I tried to reproduce it and could only do so by following these steps: - create a musical notation statement for some lexeme. - disable the extension entirely - purge&load the lexeme page - then you'll see error formatting the score property (missing datatype) - try to edit the score statement - then you can see similar error in js console and given that situation, only enabling the extension and following these steps would fix it again: - load the lexeme page (do not purge) - then you'll see error formatting the score property (missing datatype) - try to edit the score - then you don't see and error in js console - purge*load the lexeme page - then you'll see the score rendered correctly - try to edit the score property - then you don't see and error in js console The resource loader already have ETag header <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/includes/resourceloader/ResourceLoader.php#762> being generated, and DataTypesModule modifies the final version when data types list is changed (only the keys) <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/repo/includes/Modules/DataTypesModule.php#188>. This is leaving me thinking that either: - I'm missing something regarding when/how resource loader might be caching datatypes on the frontend, or - the issue is actually caused by cached pages on the BE rather than localStorage entries on the FE. - We can have look together this week when you are back, or before then if you get the chance to add more info on how you can reproduce it that'd be great! TASK DETAIL https://phabricator.wikimedia.org/T216728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, Addshore, Onmir, DannyS712, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, Jonas, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
