Tarrow added a comment.
I took a little look at this and I'm not feeling super clear on what the acceptance criteria are. My immediate thoughts would be that baseRevId not equalling the latest id shouldn't immediately result in a conflict. @Addshore could you maybe give some examples in the acceptance criteria to make it explicit what the expected behaviour is? Trying to mimic similar functionality from existing modules is hard because the checks are apparently spread about a bit. e.g. this red herring in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/a7db4c9fd88bc1ddfdf3b5266b399cff7e808954/repo/includes/Api/EditEntity.php#L198 which makes the check look much simpler than I would expect it is TASK DETAIL https://phabricator.wikimedia.org/T217243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Tarrow Cc: Tarrow, gerritbot, Addshore, Aklapper, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
