alaa_wmde added a comment.
**findings from reading through code again:** current logic and status quo: in wikibase, explained here T126231 <https://phabricator.wikimedia.org/T126231> in lexeme, there was no such logic in lexeme -> we added very basic `baserevid !== latestrevid` If I understand correctly, I think wikibase is not doing what we think it is. Wikibase only checks that the patch is valid on both base and current revisions, but does not check diff (as far as I could see in code) between the two. If that is true, then the current logic we did for lexeme is a better edit conflict prevention than what's in wikibase, and probably we can go with it for this iteration and leave implementing more sophisticated diffing and conflict detection for a later one. But that might not be true. If someone knows from the top of their head I'd appreciate a shout. Otherwise, I'll have to go deeper later and figure out for sure. TASK DETAIL https://phabricator.wikimedia.org/T217243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Tarrow, gerritbot, Addshore, Aklapper, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
