Krinkle added a comment.
In T97891#5083116 <https://phabricator.wikimedia.org/T97891#5083116>, @Jdlrobson wrote: > > t's been visible on Minerva/MobileFrontend for years without issue, > > @krinkle that's not true. Your patch https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/500814/1/includes/skins/SkinMinerva.php is why the h1 is present on Minerva. No, it's not. Take another look and explain where the previous code results in the Minerva method not returning an `<h1>` element. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Johan, TerraCodes, Liuxinyu970226, Krinkle, gerritbot, KLans_WMF, adrianheine, Florian, Aklapper, Jdlrobson, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Luke081515, Wikidata-bugs, aude, Isarra, TheDJ, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
